[webkit-reviews] review granted: [Bug 204445] add ASSERT_NOT_REACHED_WITH_MESSAGE and RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE : [Attachment 384043] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 21 04:01:31 PST 2019


Antti Koivisto <koivisto at iki.fi> has granted Tuomas Karkkainen
<tuomas.webkit at apple.com>'s request for review:
Bug 204445: add ASSERT_NOT_REACHED_WITH_MESSAGE and
RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE
https://bugs.webkit.org/show_bug.cgi?id=204445

Attachment 384043: proposed patch

https://bugs.webkit.org/attachment.cgi?id=384043&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 384043
  --> https://bugs.webkit.org/attachment.cgi?id=384043
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384043&action=review

> Source/WTF/wtf/Assertions.h:315
> +#define ASSERT_NOT_REACHED_WITH_MESSAGE(...) ((void)0)

This too should be inside #ifdef __cplusplus for consistency.


More information about the webkit-reviews mailing list