[webkit-reviews] review granted: [Bug 204424] Web Inspector: call frames from blackboxed scripts should be visually distinct : [Attachment 383992] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 21 03:30:41 PST 2019


Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 204424: Web Inspector: call frames from blackboxed scripts should be
visually distinct
https://bugs.webkit.org/show_bug.cgi?id=204424

Attachment 383992: Patch

https://bugs.webkit.org/attachment.cgi?id=383992&action=review




--- Comment #3 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 383992
  --> https://bugs.webkit.org/attachment.cgi?id=383992
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383992&action=review

> Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js:96
> +		   tooltipSuffix += "\n\n" + WI.UIString("Script ignored when
debugging");

This should mention black boxing as a reason why it was ignored.


More information about the webkit-reviews mailing list