[webkit-reviews] review granted: [Bug 204442] [JSC] Extend MacroAssemblerARM64::load/store for datasize = 16 : [Attachment 384029] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 21:57:13 PST 2019

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 204442: [JSC] Extend MacroAssemblerARM64::load/store for datasize = 16

Attachment 384029: Patch


--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 384029
  --> https://bugs.webkit.org/attachment.cgi?id=384029

View in context: https://bugs.webkit.org/attachment.cgi?id=384029&action=review

r=me with fixes.

>>> Source/JavaScriptCore/assembler/testmasm.cpp:1137
>>> +	 });
>> How is this test case different than the one immediately above it?
> nullptr is always invalid logical imm in ARM64, so this takes the path this
patch is fixing.

Yusuke told me offline that his intent is to take the !logicalImm.isValid()
case in or16.  For that, we need to pass TrustedImm(0), not

More information about the webkit-reviews mailing list