[webkit-reviews] review canceled: [Bug 204437] [MSVC] error C2039: 'weakPtrFactory': is not a member of 'WebCore::DocumentStorageAccess::requestStorageAccess::<lambda_3f2cfd7704f93d8fe19d5b5f064f8add>' : [Attachment 384020] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 20:02:16 PST 2019


Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 204437: [MSVC] error C2039: 'weakPtrFactory': is not a member of
'WebCore::DocumentStorageAccess::requestStorageAccess::<lambda_3f2cfd7704f93d8f
e19d5b5f064f8add>'
https://bugs.webkit.org/show_bug.cgi?id=204437

Attachment 384020: Patch

https://bugs.webkit.org/attachment.cgi?id=384020&action=review




--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 384020
  --> https://bugs.webkit.org/attachment.cgi?id=384020
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384020&action=review

> Source/WebCore/ChangeLog:11
> +	   the inner lambda.

It seems that the outer lambda is executed in the main thread. It's safe to
dereference the weak ptr in the outer lambda. I don't need to create two weak
ptrs. Will fix.


More information about the webkit-reviews mailing list