[webkit-reviews] review granted: [Bug 204434] Crash at com.apple.WebCore: -[WebRevealHighlight revealContext:drawRectsForItem:] : [Attachment 384016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 18:09:13 PST 2019


Megan Gardner <megan_gardner at apple.com> has granted Conrad Shultz
<conrad_shultz at apple.com>'s request for review:
Bug 204434: Crash at com.apple.WebCore: -[WebRevealHighlight
revealContext:drawRectsForItem:]
https://bugs.webkit.org/show_bug.cgi?id=204434

Attachment 384016: Patch

https://bugs.webkit.org/attachment.cgi?id=384016&action=review




--- Comment #3 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 384016
  --> https://bugs.webkit.org/attachment.cgi?id=384016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384016&action=review

r+ as long as you make sure that old systems aren't going to be broken.

> Source/WebCore/editing/cocoa/DictionaryLookup.mm:82
>  }

I know I did this on purpose, I believe so that it would work on older 32 bit
systems, but we might not compile for them anymore. Please verify that this is
true before removing.

> Source/WebCore/editing/cocoa/DictionaryLookup.mm:-101
> -

Ditto.


More information about the webkit-reviews mailing list