[webkit-reviews] review granted: [Bug 204426] run-webkit-tests: Do not create global SystemHost objects : [Attachment 383997] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 16:48:10 PST 2019


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 204426: run-webkit-tests: Do not create global SystemHost objects
https://bugs.webkit.org/show_bug.cgi?id=204426

Attachment 383997: Patch

https://bugs.webkit.org/attachment.cgi?id=383997&action=review




--- Comment #2 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 383997
  --> https://bugs.webkit.org/attachment.cgi?id=383997
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383997&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:168
> +    def device_by_filter(filter, host=None):

missing 'host = host or SystemHost()' in this function?


More information about the webkit-reviews mailing list