[webkit-reviews] review granted: [Bug 204412] [LFC][IFC] Cache InlinteTextItem width when possible : [Attachment 383965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 09:50:43 PST 2019


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 204412: [LFC][IFC] Cache InlinteTextItem width when possible
https://bugs.webkit.org/show_bug.cgi?id=204412

Attachment 383965: Patch

https://bugs.webkit.org/attachment.cgi?id=383965&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 383965
  --> https://bugs.webkit.org/attachment.cgi?id=383965
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383965&action=review

> Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:93
> +    auto inlineItemWidth = [&] (auto startPosition, auto length) ->
Optional<LayoutUnit> {

"[](#spacing-lambda-paren) Do not place spaces between square brackets and
parentheses of a lambda function but do place a space before braces."

You r+'d it!


More information about the webkit-reviews mailing list