[webkit-reviews] review granted: [Bug 204404] Regression (r252680): JSCOnly build broken: no matching function for call to JSC::DFG::SpeculativeJIT::jsValueResult : [Attachment 383963] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 204404: Regression (r252680): JSCOnly build broken: no matching function
for call to JSC::DFG::SpeculativeJIT::jsValueResult
https://bugs.webkit.org/show_bug.cgi?id=204404

Attachment 383963: Patch

https://bugs.webkit.org/attachment.cgi?id=383963&action=review




--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 383963
  --> https://bugs.webkit.org/attachment.cgi?id=383963
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383963&action=review

r=me. I’ll let you decide if you want to wait on having the baseline use the
IC.

> Source/JavaScriptCore/bytecode/AccessCase.cpp:1154
> +		   jit.loadValue(CCallHelpers::BaseIndex(scratchGPR,
scratch2GPR, CCallHelpers::TimesEight), JSValueRegs::payloadOnly(scratchGPR));

This won’t work for 32-bit. Is the goal just to get it to compile?

> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:-149
> -    callOperation(operationGetByVal, dst, m_codeBlock->globalObject(),
JSValueRegs(regT1, regT0), JSValueRegs(regT3, regT2));

Why not wait to do this until it all works?