[webkit-reviews] review denied: [Bug 204407] Move some alignment tests to the wpt folder : [Attachment 383957] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 05:52:06 PST 2019

Manuel Rego Casasnovas <rego at igalia.com> has denied rmonteriso at igalia.com's
request for review:
Bug 204407: Move some alignment tests to the wpt folder

Attachment 383957: Patch


--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 383957
  --> https://bugs.webkit.org/attachment.cgi?id=383957

View in context: https://bugs.webkit.org/attachment.cgi?id=383957&action=review

Thanks for working on this, but you need to do some changes on this patch.

> LayoutTests/ChangeLog:8
> +	   Replacing some tests from fast/css-grid/alignment to the web
platform test folder

The tests are already upstream in WPT, so this is basically importing them and
removing the duplicates in WebKit local tests.
It'd be nice if you explain that on the ChangeLog properly.

> LayoutTests/ChangeLog:10
> +	   *

This doesn't seem accurate.

ChangeLog is auto-generated, so it should include automatically all the tests
you're removing.

> LayoutTests/ChangeLog:662
> +	   <rdar://problem/56801615>

Your patch shouldn't include changes in other parts of the ChangeLog.
I guess your editor was removing trailing white-spaces or something like that
and causing the changes here.

More information about the webkit-reviews mailing list