[webkit-reviews] review granted: [Bug 204188] [Cocoa] Add ui-sans-serif as a sibling to ui-serif, ui-monospace, and ui-rounded : [Attachment 383564] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 19 19:52:17 PST 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 204188: [Cocoa] Add ui-sans-serif as a sibling to ui-serif, ui-monospace,
and ui-rounded
https://bugs.webkit.org/show_bug.cgi?id=204188

Attachment 383564: Patch

https://bugs.webkit.org/attachment.cgi?id=383564&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 383564
  --> https://bugs.webkit.org/attachment.cgi?id=383564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383564&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1272
>      Optional<SystemFontDatabaseCoreText::ClientUse> designSystemUI;

These words don't tell me anything. "client use"? "design system UI" - is that
a job title?


More information about the webkit-reviews mailing list