[webkit-reviews] review granted: [Bug 204341] [Win] Implement WTF::ThreadSpecific in WTF::Thread : [Attachment 383851] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 19 19:23:33 PST 2019

Brent Fulgham <bfulgham at webkit.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 204341: [Win] Implement WTF::ThreadSpecific in WTF::Thread

Attachment 383851: Patch


--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 383851
  --> https://bugs.webkit.org/attachment.cgi?id=383851

View in context: https://bugs.webkit.org/attachment.cgi?id=383851&action=review

> Source/WTF/wtf/ThreadSpecific.h:103
> +    void static destroy(void* ptr);

I think we can remove THREAD_SPECIFIC_CALL entirely now.

> Source/WTF/wtf/Threading.h:114
> +    class SpecificStorage {

Should this class be protected by OS(WINDOWS)?

More information about the webkit-reviews mailing list