[webkit-reviews] review granted: [Bug 179411] getUserMedia echoCancellation constraint has no affect : [Attachment 383926] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 179411: getUserMedia echoCancellation constraint has no affect
https://bugs.webkit.org/show_bug.cgi?id=179411

Attachment 383926: Patch

https://bugs.webkit.org/attachment.cgi?id=383926&action=review




--- Comment #11 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 383926
  --> https://bugs.webkit.org/attachment.cgi?id=383926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383926&action=review

> Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:236
> +    if (!enableEchoCancellation())
> +	   addHum(NoiseVolume, NoiseFrequency, rate, 0, m_bipBopBuffer.data(),
sampleCount);

Great idea!

> LayoutTests/webrtc/routines.js:123
> +	      if (!results.heardNoise)
> +		   results.heardNoise = hasFrequency(3000);
> +
> +	       if (results.heardHum && results.heardBip && results.heardBop &&
results.heardNoise)
>		   done();

Nit: the indentation is wrong here.