[webkit-reviews] review granted: [Bug 204332] Nullptr crash in Node::setTextContent via Document::setTitle if title element is removed before setTextContent call. : [Attachment 383904] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 19 16:52:45 PST 2019


Ryosuke Niwa <rniwa at webkit.org> has granted Sunny He <sunny_he at apple.com>'s
request for review:
Bug 204332: Nullptr crash in Node::setTextContent via Document::setTitle if
title element is removed before setTextContent call.
https://bugs.webkit.org/show_bug.cgi?id=204332

Attachment 383904: Patch

https://bugs.webkit.org/attachment.cgi?id=383904&action=review




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 383904
  --> https://bugs.webkit.org/attachment.cgi?id=383904
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383904&action=review

> LayoutTests/fast/dom/Document/title-property-set-with-dom-event-svg.html:5
> +    if (window.testRunner) {

WebKit style is to not use curly braces around a single line statement but it’s
okay to keep it like this for tests.


More information about the webkit-reviews mailing list