[webkit-reviews] review granted: [Bug 204330] Web Inspector: Local Overrides: the placeholder for the MIME type, status code, and status text is the same as the placeholder URL : [Attachment 383833] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 19 12:01:21 PST 2019
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 204330: Web Inspector: Local Overrides: the placeholder for the MIME type,
status code, and status text is the same as the placeholder URL
https://bugs.webkit.org/show_bug.cgi?id=204330
Attachment 383833: Patch
https://bugs.webkit.org/attachment.cgi?id=383833&action=review
--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 383833
--> https://bugs.webkit.org/attachment.cgi?id=383833
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=383833&action=review
rs=me
> Source/WebInspectorUI/UserInterface/Views/DataGridNode.js:37
> + this._selectable = selectable !== undefined ? selectable : true;
> + this._copyable = copyable !== undefined ? copyable : true;
> + this._editable = editable !== undefined ? editable : true;
Can we use nullish operators now?
selectable ?? true
More information about the webkit-reviews
mailing list