[webkit-reviews] review granted: [Bug 204346] [IndexedDB] IndexedDB's threading assertion should respect Web thread : [Attachment 383855] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 19 11:47:45 PST 2019
Daniel Bates <dbates at webkit.org> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 204346: [IndexedDB] IndexedDB's threading assertion should respect Web
thread
https://bugs.webkit.org/show_bug.cgi?id=204346
Attachment 383855: Patch
https://bugs.webkit.org/attachment.cgi?id=383855&action=review
--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 383855
--> https://bugs.webkit.org/attachment.cgi?id=383855
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=383855&action=review
This patch looks good.
> Source/WebCore/Modules/indexeddb/IDBActiveDOMObject.h:41
> + ASSERT(canAccessThreadLocalDataForThread(m_originThread.get()));
Naming is ok-as is. The slightly less verbose name would be
"canAccessThreadLocalData". That's no need for "ForThread" as that can be
implied by the passed argument.
> Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:54
> + ASSERT(canAccessThreadLocalDataForThread(m_originThread.get()));
This is ok as-is. The .get() is unnecessary because Ref<> overloads operator
T&().
More information about the webkit-reviews
mailing list