[webkit-reviews] review granted: [Bug 204354] [LFC][IFC] Assign inlineCapacity to various inline run vectors. : [Attachment 383874] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 19 09:16:11 PST 2019

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 204354: [LFC][IFC] Assign inlineCapacity to various inline run vectors.

Attachment 383874: Patch


--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 383874
  --> https://bugs.webkit.org/attachment.cgi?id=383874

View in context: https://bugs.webkit.org/attachment.cgi?id=383874&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingState.h:43
> +using InlineItems = Vector<std::unique_ptr<InlineItem>, 30>;
> +using InlineRuns = Vector<std::unique_ptr<Display::Run>, 10>;
> +using LineBoxes = Vector<std::unique_ptr<LineBox>, 5>;

Maybe some of these can be Vector<Foo,..> instead of
Vector<std::unique_ptr<Foo>,...> too? Would probably be faster if we can avoid
heap allocations.

> Source/WebCore/layout/inlineformatting/InlineLine.h:72
> +	   Run& operator=(Run&& other);

I don't see implementation of this. I suppose it is not needed if things

If you need it, you can default it too.

More information about the webkit-reviews mailing list