[webkit-reviews] review granted: [Bug 201422] REGRESSION(r249428): [GStreamer] VP9 video rendered green : [Attachment 383761] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 201422: REGRESSION(r249428): [GStreamer] VP9 video rendered green
https://bugs.webkit.org/show_bug.cgi?id=201422

Attachment 383761: Patch

https://bugs.webkit.org/attachment.cgi?id=383761&action=review




--- Comment #42 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 383761
  --> https://bugs.webkit.org/attachment.cgi?id=383761
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383761&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1218
>      if (webkitGstCheckVersion(1, 16, 2) ||
getenv("WEBKIT_GST_NO_RGBA_CONVERSION")) {
> -	   GRefPtr<GstPad> pad = adoptGRef(gst_element_get_static_pad(upload,
"sink"));
> -	   gst_element_add_pad(videoSink, gst_ghost_pad_new("sink",
pad.get()));
> +	   caps = adoptGRef(gst_caps_from_string("video/x-raw, format =
(string) " GST_GL_CAPS_FORMAT));
>      } else {

{} can be removed because this is a one-line block now.