[webkit-reviews] review granted: [Bug 204286] [bmalloc] Some chunks have unused region in the tail of its memory block. : [Attachment 383787] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 18 18:44:38 PST 2019


Yusuke Suzuki <ysuzuki at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 204286: [bmalloc] Some chunks have unused region in the tail of its memory
block.
https://bugs.webkit.org/show_bug.cgi?id=204286

Attachment 383787: PATCH

https://bugs.webkit.org/attachment.cgi?id=383787&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 383787
  --> https://bugs.webkit.org/attachment.cgi?id=383787
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=383787&action=review

r=me

> Source/bmalloc/ChangeLog:12
> +	   a chunk can hold 42 pages and its size is 24k * 42 = 1008k which is
smaller than chunkSize = 1024k.

I was a bit considering about huge-page things. But it seems that chunkSize is
1MB (not 2MB), so we are not using huge-page feature so aggressively.


More information about the webkit-reviews mailing list