[webkit-reviews] review granted: [Bug 204333] Always enable Optional<OptionsStorage::Size> parse(const char* string) for OS(DARWIN). : [Attachment 383832] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 18 18:39:44 PST 2019


Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 204333: Always enable Optional<OptionsStorage::Size> parse(const char*
string) for OS(DARWIN).
https://bugs.webkit.org/show_bug.cgi?id=204333

Attachment 383832: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=383832&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 383832
  --> https://bugs.webkit.org/attachment.cgi?id=383832
proposed patch.

r=me. BTW, how about replacing size_t with uint64_t (or uint32_t) completely?


More information about the webkit-reviews mailing list