[webkit-reviews] review granted: [Bug 204300] [Cocoa] Add WKUIDelegate SPI to inform clients when a _WKInspector attaches to a WKWebView : [Attachment 383799] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 204300: [Cocoa] Add WKUIDelegate SPI to inform clients when a _WKInspector
attaches to a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=204300

Attachment 383799: Patch

https://bugs.webkit.org/attachment.cgi?id=383799&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 383799
  --> https://bugs.webkit.org/attachment.cgi?id=383799
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383799&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:240
> +- (void)_webView:(WKWebView *)webView didAttachInspector:(_WKInspector
*)inspector WK_API_AVAILABLE(macos(WK_MAC_TBA));
> +#endif // !TARGET_OS_IPHONE

Wouldn't it be more accurate to have this be in its own `#if TARGET_OS_MAC`?