[webkit-reviews] review granted: [Bug 204069] OverConstrainedError is missing 'name' property : [Attachment 383763] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 204069: OverConstrainedError is missing 'name' property
https://bugs.webkit.org/show_bug.cgi?id=204069

Attachment 383763: Patch

https://bugs.webkit.org/attachment.cgi?id=383763&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 383763
  --> https://bugs.webkit.org/attachment.cgi?id=383763
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383763&action=review

> Source/WebCore/ChangeLog:8
> +	   No new tests, existing test and results updated.

There is one failing test on Mac that probably needs to get updated.

>
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/GUM-impossible
-constraint.https-expected.txt:8
> +FAIL Tests that setting an impossible constraint in getUserMedia fails
assert_equals: The name of the not satisfied error is given in error.constraint
expected "width" but got ""

We should look at these tests, maybe we should update them since we are not
exposing the constraint if device info is not granted.