[webkit-reviews] review denied: [Bug 204306] Web Inspector: DOM.highlightSelector should work for "div, div::before" : [Attachment 383770] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 204306: Web Inspector: DOM.highlightSelector should work for "div,
div::before"
https://bugs.webkit.org/show_bug.cgi?id=204306

Attachment 383770: Patch

https://bugs.webkit.org/attachment.cgi?id=383770&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 383770
  --> https://bugs.webkit.org/attachment.cgi?id=383770
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383770&action=review

Code changes look good.

We need to add a test for DOM.highlightSelector, it doesn't need to be super
complicated but it should show a progression with this change (or at least
exercise the obvious cases this should handle.)

> Source/WebCore/ChangeLog:7
> +

You should say how it is currently broken. Maybe mention that you need to
deduplicate the NodeList to make the given example not return wrong results.