[webkit-reviews] review granted: [Bug 199645] TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON is a flaky crash : [Attachment 383644] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 18 14:03:38 PST 2019
Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 199645: TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON is a
flaky crash
https://bugs.webkit.org/show_bug.cgi?id=199645
Attachment 383644: Patch
https://bugs.webkit.org/attachment.cgi?id=383644&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 383644
--> https://bugs.webkit.org/attachment.cgi?id=383644
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=383644&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2337
> - EXPECT_EQ(3u, backForwardListURLs.size());
> + RELEASE_ASSERT(backForwardListURLs.size() == 3u);
I don't see why this is necessary.
More information about the webkit-reviews
mailing list