[webkit-reviews] review granted: [Bug 194888] BigInt should store its data in the primitive gigacage. : [Attachment 383732] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 17 23:56:33 PST 2019

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 194888: BigInt should store its data in the primitive gigacage.

Attachment 383732: Patch


--- Comment #10 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 383732
  --> https://bugs.webkit.org/attachment.cgi?id=383732

View in context: https://bugs.webkit.org/attachment.cgi?id=383732&action=review

r=me with fix.

> Source/JavaScriptCore/runtime/JSBigInt.cpp:111
> +    ASSERT(data);

This is not strictly needed because malloc() should crash on failure to
allocate, but I suppose it doesn't hurt.

> Source/JavaScriptCore/runtime/JSBigInt.h:56
>      JSBigInt(VM&, Structure*, unsigned length);

Shouldn't this line be removed?  This constructor doesn't exist anymore.

More information about the webkit-reviews mailing list