[webkit-reviews] review denied: [Bug 204260] Make WebProcessProxy::WebProcessProxyMap contain WeakPtrs instead of raw pointers. : [Attachment 383661] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 204260: Make WebProcessProxy::WebProcessProxyMap contain WeakPtrs instead
of raw pointers.
https://bugs.webkit.org/show_bug.cgi?id=204260

Attachment 383661: Patch

https://bugs.webkit.org/attachment.cgi?id=383661&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 383661
  --> https://bugs.webkit.org/attachment.cgi?id=383661
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383661&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:4959
> +	       if (page && page->sessionID().isEphemeral())

I really do not think we should do this. It is crazy to null checks pages in
the map. By definition, pages are only in the map if they are alive. This is
not the right way to fix the bug.