[webkit-reviews] review granted: [Bug 204109] REGRESSION (iOS 13.3): WKWebView does not include cookies in cross-origin images : [Attachment 383709] Proposed patch addressing Chris's comments

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 204109: REGRESSION (iOS 13.3): WKWebView does not include cookies in
cross-origin images
https://bugs.webkit.org/show_bug.cgi?id=204109

Attachment 383709: Proposed patch addressing Chris's comments

https://bugs.webkit.org/attachment.cgi?id=383709&action=review




--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 383709
  --> https://bugs.webkit.org/attachment.cgi?id=383709
Proposed patch addressing Chris's comments

View in context: https://bugs.webkit.org/attachment.cgi?id=383709&action=review

> Source/WebKit/NetworkProcess/NetworkSession.cpp:134
> +	   if (auto* storageSession = networkStorageSession())

Could this be move to the top of the method to avoid the duplication?

ASSERT(!m_isInvalidated);
if (auto* storageSession = networkStorageSession())
    storageSession->setResourceLoadStatisticsEnabled(enable);