[webkit-reviews] review granted: [Bug 204214] [JSC] Anonymous built-in functions should have empty string for a name : [Attachment 383663] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 204214: [JSC] Anonymous built-in functions should have empty string for a
name
https://bugs.webkit.org/show_bug.cgi?id=204214

Attachment 383663: Patch

https://bugs.webkit.org/attachment.cgi?id=383663&action=review




--- Comment #9 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 383663
  --> https://bugs.webkit.org/attachment.cgi?id=383663
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383663&action=review

r=me with nits.

> Source/JavaScriptCore/builtins/PromiseConstructor.js:244
> -	       function @resolve(resolution) {
> +	       function (resolution) {
>		   return
@resolvePromiseWithFirstResolvingFunctionCallCheck(capturedPromise,
resolution);
>	       },
> -	       function @reject(reason) {
> +	       function (reason) {
>		   return
@rejectPromiseWithFirstResolvingFunctionCallCheck(capturedPromise, reason);

You need to change InternalPromise constructor's one too.

> Source/JavaScriptCore/runtime/ProxyRevoke.cpp:54
> +    Base::finishCreation(vm, ""_s);

Pass `emptyString()`.