[webkit-reviews] review granted: [Bug 204264] [JSC] DFG strength reduction should define "groups" for RegExp constant-folded result : [Attachment 383671] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 17:22:56 PST 2019


Michael Saboff <msaboff at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 204264: [JSC] DFG strength reduction should define "groups" for RegExp
constant-folded result
https://bugs.webkit.org/show_bug.cgi?id=204264

Attachment 383671: Patch

https://bugs.webkit.org/attachment.cgi?id=383671&action=review




--- Comment #3 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 383671
  --> https://bugs.webkit.org/attachment.cgi?id=383671
Patch

r=me.  Always creating "groups" including creating an undefined "groups" for
str.match() results where there aren't any named capture groups is compliant
with the ECMA-262 spec.


More information about the webkit-reviews mailing list