[webkit-reviews] review granted: [Bug 204233] AX: Update style of lambda in isolated tree : [Attachment 383628] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 204233: AX: Update style of lambda in isolated tree
https://bugs.webkit.org/show_bug.cgi?id=204233

Attachment 383628: patch

https://bugs.webkit.org/attachment.cgi?id=383628&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 383628
  --> https://bugs.webkit.org/attachment.cgi?id=383628
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383628&action=review

Change looks great but I am not sure I understand why the code was working.

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp:98
> -	   setProperty(AXPropertyName::MathLineThickness,
object.mathLineThickness());Ã¥Ã
> +	   setProperty(AXPropertyName::MathLineThickness,
object.mathLineThickness());

Wow, what was that?

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp:195
> -	   [&] (Optional<AXID> typedValue) {
> -	       if (!typedValue)
> -		   return InvalidAXID;
> -	   return typedValue.value();
> -	   },
> +	   [] (AXID& typedValue) { return typedValue; },

This looks great.

I don’t understand why the old code even compiled, though! And if it did
compile, why did it ever work. There’s no Optional<AXID> in the Variant.

Do we have test coverage for this?