[webkit-reviews] review granted: [Bug 204248] CRASH in SourceBuffer::removeCodedFrames() : [Attachment 383651] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 16:28:06 PST 2019


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted  review:
Bug 204248: CRASH in SourceBuffer::removeCodedFrames()
https://bugs.webkit.org/show_bug.cgi?id=204248

Attachment 383651: Patch

https://bugs.webkit.org/attachment.cgi?id=383651&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 383651
  --> https://bugs.webkit.org/attachment.cgi?id=383651
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383651&action=review

r=me

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:805
> +    if (start >= end)

Wasn’t there a second place where this check could be added that was missing
it?


More information about the webkit-reviews mailing list