[webkit-reviews] review granted: [Bug 204178] Web Inspector: Sources: move the "Local Override..." creation context menu item from the Breakpoints section options menu to the Create Resource menu : [Attachment 383512] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 16:09:45 PST 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 204178: Web Inspector: Sources: move the "Local Override..." creation
context menu item from the Breakpoints section options menu to the Create
Resource menu
https://bugs.webkit.org/show_bug.cgi?id=204178

Attachment 383512: Patch

https://bugs.webkit.org/attachment.cgi?id=383512&action=review




--- Comment #9 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 383512
  --> https://bugs.webkit.org/attachment.cgi?id=383512
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383512&action=review

rs=me

>
Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:664
> +	       if (!this._localOverridesTreeOutline.children.length)
> +		   this._localOverridesContainer.hidden = true;

Is there another beep and return after this which needs the same thing? Or did
that go away.


More information about the webkit-reviews mailing list