[webkit-reviews] review granted: [Bug 204234] Add more release logging for network load restarts : [Attachment 383627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 15:07:27 PST 2019


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 204234: Add more release logging for network load restarts
https://bugs.webkit.org/show_bug.cgi?id=204234

Attachment 383627: Patch

https://bugs.webkit.org/attachment.cgi?id=383627&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 383627
  --> https://bugs.webkit.org/attachment.cgi?id=383627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383627&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:1265
> +	   RELEASE_LOG_IF_ALLOWED("serviceWorkerDidNotHandle: (pageID = %"
PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ") Restarting network
load", m_parameters.webPageID.toUInt64(), m_parameters.webFrameID.toUInt64(),
m_parameters.identifier);

Isn’t it a bit redundant with serviceworkerfetchtask logging?


More information about the webkit-reviews mailing list