[webkit-reviews] review granted: [Bug 204199] Reduce structure copies when creating an API::FrameInfo : [Attachment 383588] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 10:29:23 PST 2019

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 204199: Reduce structure copies when creating an API::FrameInfo

Attachment 383588: Patch


--- Comment #8 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 383588
  --> https://bugs.webkit.org/attachment.cgi?id=383588

View in context: https://bugs.webkit.org/attachment.cgi?id=383588&action=review

> Source/WebKit/UIProcess/API/APIFrameInfo.cpp:61
> +FrameInfo::~FrameInfo() = default;

We have to say this because of the virtual ness, but can't it be in the header?

More information about the webkit-reviews mailing list