[webkit-reviews] review granted: [Bug 204192] [WinCairo] dead lock in Thread::destructTLS : [Attachment 383602] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 204192: [WinCairo] dead lock in Thread::destructTLS
https://bugs.webkit.org/show_bug.cgi?id=204192

Attachment 383602: Patch

https://bugs.webkit.org/attachment.cgi?id=383602&action=review




--- Comment #19 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 383602
  --> https://bugs.webkit.org/attachment.cgi?id=383602
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383602&action=review

r=me

>> Source/WTF/wtf/win/ThreadingWin.cpp:268
>> +static Mutex threadMapMutex;
> 
> What happens if you use std::mutex? I'm guessing this is the issue.

Can you add a comment that describes why we are using Mutex instead of WordLock
here?