[webkit-reviews] review granted: [Bug 203734] Flaky API Test TestWebKitAPI.ServiceWorkers.ThrottleCrash : [Attachment 383505] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 203734: Flaky API Test TestWebKitAPI.ServiceWorkers.ThrottleCrash
https://bugs.webkit.org/show_bug.cgi?id=203734

Attachment 383505: Patch

https://bugs.webkit.org/attachment.cgi?id=383505&action=review




--- Comment #12 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 383505
  --> https://bugs.webkit.org/attachment.cgi?id=383505
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383505&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:581
> +	   { "/test.mp4", { "test!", {{ "Content-Type", "video/test" }}}},

Looks nice and easy to understand!

> Tools/TestWebKitAPI/cocoa/HTTPServer.h:41
> +    HTTPServer(std::initializer_list<std::pair<String, HTTPResponse>>);

explicit and &&

> Tools/TestWebKitAPI/cocoa/HTTPServer.h:53
> +    HTTPResponse(String&& body)

explicit.

> Tools/TestWebKitAPI/cocoa/HTTPServer.h:63
> +    HTTPResponse& operator=(HTTPResponse&&) = default;

Why do we need all of these?