[webkit-reviews] review granted: [Bug 173332] HTML5 audio .ended event not fired when app in background or phone screen is off : [Attachment 383493] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 173332: HTML5 audio .ended event not fired when app in background or phone
screen is off
https://bugs.webkit.org/show_bug.cgi?id=173332

Attachment 383493: Patch

https://bugs.webkit.org/attachment.cgi?id=383493&action=review




--- Comment #10 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 383493
  --> https://bugs.webkit.org/attachment.cgi?id=383493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383493&action=review

r=me once the bots are happy

> LayoutTests/media/audio-background-playback-playlist-expected.txt:2
> +RUN(internals.setMediaElementRestrictions(audio,
"RequireUserGestureForAudioRateChange"))

Oops, look like you need to regenerate this file.

> LayoutTests/media/audio-background-playback-playlist.html:20
> +	   run('audio.load()');
> +	  
testExpected('internals.bestMediaElementForShowingPlaybackControlsManager("NowP
laying")', audio);

It would be better to test for NowPlaying status after a delay, e.g. after an
'emptied' event.