[webkit-reviews] review granted: [Bug 204149] [JSC] BlockDirectory's bits should be compact : [Attachment 383532] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 13 18:36:59 PST 2019

Robin Morisset <rmorisset at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 204149: [JSC] BlockDirectory's bits should be compact

Attachment 383532: Patch


--- Comment #20 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 383532
  --> https://bugs.webkit.org/attachment.cgi?id=383532

View in context: https://bugs.webkit.org/attachment.cgi?id=383532&action=review


> Source/JavaScriptCore/heap/BlockDirectoryBits.h:156
> +	       for (unsigned i =
BlockDirectoryBitVectorView<kind>::arrayLength(); i--;)

Is there a reason for the previous function using Base::arrayLength() while
this one is using BlockDirectoryBitVectorView<kind>::arrayLength() ?

> Source/JavaScriptCore/heap/BlockDirectoryBits.h:191
> +    BlockDirectoryBitVectorRef<Kind::capitalBitName> lowerBitName() \

I don't think this function is useful as long as you have the one above.
Either delete it, or make it return a const

More information about the webkit-reviews mailing list