[webkit-reviews] review granted: [Bug 203852] REGRESSION: WKWebView navigation fails when navigating from about:blank : [Attachment 383475] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 203852: REGRESSION: WKWebView navigation fails when navigating from
about:blank
https://bugs.webkit.org/show_bug.cgi?id=203852

Attachment 383475: Patch

https://bugs.webkit.org/attachment.cgi?id=383475&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 383475
  --> https://bugs.webkit.org/attachment.cgi?id=383475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383475&action=review

>>> Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:98
>>> +TEST(WKWebView, RepeatLoadFileURL)
>> 
>> It seems like we should also have a test of the case that we have revoked
our permission, and should not have it. Can we test that the extension was
properly revoked and the load fails in that case (for example a successful load
where we revoke access, but a simulated attacker tries to load the file again)
> 
> Having a test that makes sure the extension is revoked after a load is an
excellent idea. Would you be OK with doing this in a follow-up patch?
> 
> Thanks for reviewing :)

Sure -- a second patch to add this testing (and address any issues it
discovers) seems like a good idea, since this patch just restores original
behavior.