[webkit-reviews] review granted: [Bug 204146] [Win][DumpRenderTree][WebKitTestRunner] eventSender.keyDown should support function keys : [Attachment 383440] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 204146: [Win][DumpRenderTree][WebKitTestRunner] eventSender.keyDown should
support function keys
https://bugs.webkit.org/show_bug.cgi?id=204146

Attachment 383440: Patch

https://bugs.webkit.org/attachment.cgi?id=383440&action=review




--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 383440
  --> https://bugs.webkit.org/attachment.cgi?id=383440
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383440&action=review

r=me

>> Tools/DumpRenderTree/win/EventSender.cpp:465
>> +	    // Some keys need to turn on KF_EXTENDED explicitly
> 
> This is a hack to work around a bug of MapVirtualKey and MapVirtualKeyEx
doesn't work as expected.
> 
> MapVirtualKey(), GetKeyNameText(), and a story of how to get proper names for
the arrow keys - setnode.com
>
http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/
> 
>
http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/
#comment-1104594462

Perhaps this info should be added to the ChangeLog?