[webkit-reviews] review granted: [Bug 203646] [SVG2] Add the 'orient' property of the interface SVGMarkerElement : [Attachment 383488] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 13 14:54:26 PST 2019
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 203646: [SVG2] Add the 'orient' property of the interface SVGMarkerElement
https://bugs.webkit.org/show_bug.cgi?id=203646
Attachment 383488: Patch
https://bugs.webkit.org/attachment.cgi?id=383488&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 383488
--> https://bugs.webkit.org/attachment.cgi?id=383488
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=383488&action=review
> Source/WebCore/svg/SVGMarkerElement.h:70
> + void setOrientToAngle(SVGAngle&);
const SVGAngle& or Ref<SVGAngle>&& ? Could a null angle indicate "auto"?
> Source/WebCore/svg/SVGMarkerTypes.h:85
> + static unsigned highestEnumValue() { return SVGMarkerOrientAngle; }
Deserves a comment to explain why it's not SVGMarkerOrientAutoStartReverse
More information about the webkit-reviews
mailing list