[webkit-reviews] review granted: [Bug 204128] pageZoom/setPageZoom: should not be in a Mac-only part of WKWebView.mm : [Attachment 383469] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 204128: pageZoom/setPageZoom: should not be in a Mac-only part of
WKWebView.mm
https://bugs.webkit.org/show_bug.cgi?id=204128

Attachment 383469: Patch

https://bugs.webkit.org/attachment.cgi?id=383469&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 383469
  --> https://bugs.webkit.org/attachment.cgi?id=383469
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383469&action=review

> Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:194
> +	   id result = [self objectByEvaluatingJavaScript:@"getClientWidth()"];

It is strange that this calls a JavaScript function that is not defined in
TestWKWebView.	Please move.