[webkit-reviews] review granted: [Bug 204085] Web Inspector: "aqua" isn't detected as color : [Attachment 383303] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 13 10:29:48 PST 2019

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 204085: Web Inspector: "aqua" isn't detected as color

Attachment 383303: Patch


--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 383303
  --> https://bugs.webkit.org/attachment.cgi?id=383303

View in context: https://bugs.webkit.org/attachment.cgi?id=383303&action=review


> Source/WebInspectorUI/UserInterface/Models/Color.js:745
> +    "aqua": [0, 255, 255, 1],

We're also missing `fuchsia`, which is one of the original HTML colors ��‍♂️:
    "fuchsia": [255, 0, 255, 1],

Interestingly, both `aqua` and `fuchsia` have alternate names in CSS,
respectively being `cyan` and `magenta`.

This doesn't look to be an issue, other than that we'll instead always prefer
`aqua` over `cyan` (same with `fuchsia` over `magenta`) when generating CSS
color keyword strings simply because they're sorted alphabetically.

More information about the webkit-reviews mailing list