[webkit-reviews] review granted: [Bug 203275] [ iOS ]: Layout Test http/tests/IndexedDB/storage-limit-1.https.html is a Flaky Failure : [Attachment 383398] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 13 08:14:50 PST 2019


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 203275: [ iOS ]: Layout Test
http/tests/IndexedDB/storage-limit-1.https.html is a Flaky Failure
https://bugs.webkit.org/show_bug.cgi?id=203275

Attachment 383398: Patch

https://bugs.webkit.org/attachment.cgi?id=383398&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 383398
  --> https://bugs.webkit.org/attachment.cgi?id=383398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383398&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:62
> +    auto pendingClearCallbacks = WTFMove(m_pendingClearCallbacks);

I feel like this should be std::exchange, but I guess it's not too big of a
deal because this is in the destructor.


More information about the webkit-reviews mailing list