[webkit-reviews] review denied: [Bug 203974] WKWebView is missing an equivalent to WebKit 1's API to set the media style : [Attachment 383388] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 15:12:55 PST 2019

Alex Christensen <achristensen at apple.com> has denied Brady Eidson
<beidson at apple.com>'s request for review:
Bug 203974: WKWebView is missing an equivalent to WebKit 1's API to set the
media style

Attachment 383388: Patch


--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 383388
  --> https://bugs.webkit.org/attachment.cgi?id=383388

View in context: https://bugs.webkit.org/attachment.cgi?id=383388&action=review

> Source/WebKit/ChangeLog:11
> +	   - Expose a read/write property on WKWebView.

I assume this needs to be changed at runtime so it can't be on the
configuration.	Ok.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:325
> + at discussion The value of mediaType will override the normal value of the CSS
media property.

I don't think this description makes it easy to understand how to use this.

> Source/WebKit/UIProcess/WebPageProxy.cpp:9502
> +    m_overriddenMediaType = mediaType;

WebKitLegacy's implementation does nothing if we're setting it to the same
value.	Do we want such an optimization here?

> Source/WebKit/UIProcess/WebPageProxy.cpp:9503
> +    m_process->send(Messages::WebPage::SetOverriddenMediaType(mediaType),

This appears to be the only way to set the override in the web process.  What
if we do a cross-domain navigation?  I imagine we will probably want the same
media type unless the API has been used to change it.  Please add the string to
WebPageCreationParameters and add such a test.	Also one that sets the media
type before the first navigation.

More information about the webkit-reviews mailing list