[webkit-reviews] review granted: [Bug 201461] Support stale-while-revalidate cache strategy : [Attachment 383373] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 13:56:31 PST 2019


youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 201461: Support stale-while-revalidate cache strategy
https://bugs.webkit.org/show_bug.cgi?id=201461

Attachment 383373: Patch

https://bugs.webkit.org/attachment.cgi?id=383373&action=review




--- Comment #32 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 383373
  --> https://bugs.webkit.org/attachment.cgi?id=383373
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383373&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:323
> +	       m_pendingAsyncRevalidations.take(key);

s/take/remove

> Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:325
> +		   LOG(NetworkCache, "(NetworkProcess) Async revalidation
completed for '%s':", key.identifier().utf8().data());

I would tend to log all cases.


More information about the webkit-reviews mailing list