[webkit-reviews] review granted: [Bug 204087] AudioScheduledSourceNodes leak if they have an attached onended EventTarget : [Attachment 383309] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 10:37:22 PST 2019


Jer Noble <jer.noble at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 204087: AudioScheduledSourceNodes leak if they have an attached onended
EventTarget
https://bugs.webkit.org/show_bug.cgi?id=204087

Attachment 383309: Patch

https://bugs.webkit.org/attachment.cgi?id=383309&action=review




--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 383309
  --> https://bugs.webkit.org/attachment.cgi?id=383309
Patch

LGTM. Nice to disambiguate node->start(when) from ActiveDOMObject::start().
Windows EWS failure seems unrelated.


More information about the webkit-reviews mailing list