[webkit-reviews] review denied: [Bug 204092] [WebAssembly] Improve Wasm::LLIntGenerator : [Attachment 383316] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 08:43:54 PST 2019

Saam Barati <sbarati at apple.com> has denied Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 204092: [WebAssembly] Improve Wasm::LLIntGenerator

Attachment 383316: Patch


--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 383316
  --> https://bugs.webkit.org/attachment.cgi?id=383316

View in context: https://bugs.webkit.org/attachment.cgi?id=383316&action=review

Tests are broken

> Source/JavaScriptCore/ChangeLog:9
> +	   - Removing redundant moves when materializing constants

You should also say how, not just what

> Source/JavaScriptCore/ChangeLog:13
> +	   - Delay holding the lock in LLintPlan::compileFunction, since we do
not need to hold it while compiling.

I think you meant to say compiling the entrypoint

> Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp:85
>	   entry.function = m_createEmbedderWrapper(*entry.jit, signature,
&m_unlinkedWasmToWasmCalls[functionIndex], m_moduleInformation.get(), m_mode,

We’re sure it’s ok to call this concurrently?

More information about the webkit-reviews mailing list