[webkit-reviews] review granted: [Bug 203194] [GStreamer] Several issues while trying to play a video on NextCloud : [Attachment 383346] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 203194: [GStreamer] Several issues while trying to play a video on
NextCloud
https://bugs.webkit.org/show_bug.cgi?id=203194

Attachment 383346: Patch

https://bugs.webkit.org/attachment.cgi?id=383346&action=review




--- Comment #3 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 383346
  --> https://bugs.webkit.org/attachment.cgi?id=383346
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383346&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:468
> -		   && (GST_STATE(src) == GST_STATE_PLAYING) &&
priv->isDownloadSuspended) {
> +		   && (GST_STATE(src) == GST_STATE_PLAYING || GST_STATE(src) ==
GST_STATE_PAUSED) && priv->isDownloadSuspended) {

Could be simplified to GST_STATE(src) >= GST_STATE_PAUSED

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:38
> +#define WEBKIT_WEB_SRC_CAST(obj)	      ((WebKitWebSrc*)(obj))

Odd indentation here :)