[webkit-reviews] review granted: [Bug 204027] Add size file for CacheStorage : [Attachment 383313] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 204027: Add size file for CacheStorage
https://bugs.webkit.org/show_bug.cgi?id=204027

Attachment 383313: Patch

https://bugs.webkit.org/attachment.cgi?id=383313&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 383313
  --> https://bugs.webkit.org/attachment.cgi?id=383313
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383313&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:470
> +    m_ioQueue->dispatch([path = path.isolatedCopy(), size]() mutable {

mutable?

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:481
> +	   auto sizeString = String::number(size).utf8();

Could be a oneliner.

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:512
> +    return String::fromUTF8(buffer.data()).toUIntStrict();

toUInt64Strict

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.h:88
> +    static Optional<uint64_t> readSizeFile(const String& path);

'path' not really useful.