[webkit-reviews] review granted: [Bug 203493] [Picture-in-Picture Web API] Support picture-in-picture CSS pseudo-class : [Attachment 383252] Fix GTK build failure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 11 09:23:37 PST 2019

Dean Jackson <dino at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 203493: [Picture-in-Picture Web API] Support picture-in-picture CSS

Attachment 383252: Fix GTK build failure


--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 383252
  --> https://bugs.webkit.org/attachment.cgi?id=383252
Fix GTK build failure

View in context: https://bugs.webkit.org/attachment.cgi?id=383252&action=review

> +	   /* illegal selector list */
> +	   video, :picture-in-picture(*) {
> +	       color: rgb(255, 0, 0);
> +	   }

I'm not sure exactly what this is testing, but you don't actually test to make
sure it didn't happen.

I also suggest you add another test (probably a separate file) that exercises
the is<HTMLVideoElement>(element) part of the logic. i.e. something like

div:picture-in-picture {
  background-color: red;

More information about the webkit-reviews mailing list